Skip to content

fix(helm): decouple [discord] section from botToken presence#393

Closed
Joseph19820124 wants to merge 1 commit intoopenabdev:mainfrom
Joseph19820124:fix-helm-discord-config
Closed

fix(helm): decouple [discord] section from botToken presence#393
Joseph19820124 wants to merge 1 commit intoopenabdev:mainfrom
Joseph19820124:fix-helm-discord-config

Conversation

@Joseph19820124
Copy link
Copy Markdown

Summary

This PR decouples the [discord] section generation in config.toml from the presence of botToken at render time.

Problem

Previously, the [discord] block would only be generated if a botToken was provided to Helm. This forced users who manage secrets at runtime (e.g., via AWS Secrets Manager) to either:

  1. Provide a dummy token to Helm (confusing).
  2. Provide the real token to Helm (security risk, as it's stored in Helm history).

Solution

The template now only checks for ($cfg.discord).enabled. This allows the block to be generated while relying on runtime environment variable expansion (${DISCORD_BOT_TOKEN}) for the actual authentication.

Context

@thepagent
Copy link
Copy Markdown
Collaborator

Thank you for the contribution and for identifying this issue! I've opened #403 which rebases this fix onto current main (the Slack section already exists upstream, and the configmap condition has evolved since this PR was authored). Closing in favor of #403.

@thepagent thepagent closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Helm] Helm chart 0.7.7-beta.1: [discord] section in config.toml depends on botToken being set at render time

2 participants